Fix Curve3D::get_closest_point() broken
#69239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiongyaohua
changed the title
xiongyaohua
changed the title
|
@xiongyaohua Please write a summary of the fixed part in the commit comment, not a reference to the issue id. |
xiongyaohua
force-pushed
the
fix_69220
branch
from
429a336 to
49a1d38
Compare
done |
xiongyaohua
force-pushed
the
fix_69220
branch
2 times, most recently
from
dc36389 to
6b93e96
Compare
kleonc
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
@xiongyaohua As mentioned the commit title is preferred to be just a summary, I think the "Fix #69220" part is not desired in there. Feel free to leave it in the commit message but not in the title (the first line).
Besides that the code/changes LGTM.
xiongyaohua
force-pushed
the
fix_69220
branch
from
6b93e96 to
03c444c
Compare
The problem is caused by calling adaptive tessellation baking function by mistake, which produce too few points for straight lines. Calling the even length tessellation fix the problem. The code for `get_closest_point()` and `get_closest_offset()` are also updated. They used to assume bake interval to be exact, which is no longer true. The out dated document for `get_closest_point()` is also updated.
xiongyaohua
force-pushed
the
fix_69220
branch
from
03c444c to
69f8456
Compare
|
Thanks! |
This was referenced Dec 4, 2022
This was referenced Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #69220
The problem is caused by calling adaptive tessellation baking function by mistake, which produce too few points for straight lines. Calling the even length tessellation fix the problem. The code for
get_closest_point()andget_closest_offset()are also updated. They used to assume bake interval to be exact, which is no longer true.The out dated document for
get_closest_point()is also updated.Fix #69507 as a by product, which is caused by a typo. (
size_tinstead ofreal_t)All fixes have been applied to the Curve2D counterpart #69115.