Revert "RID: Change comparison operators to use RID_Data id instead of address" #69946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
topic:core
regression
cherrypick:3.5
lawnjelly
approved these changes
Dec 12, 2022
|
Just for reference, we decided where order wasn't important, the existing data pointer was better as there is no lookup (hence no cache misses, and no dangling RID problems), and where order matters, RIDs are not an appropriate ordering index, and we should revisit these few areas and fix them individually (especially canvas items). |
|
Cherry-picked for 3.5.2. |
akien-mga
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #59234 (comment) and #67273 for a description of the problem it causes.
The RID comparisons should be avoided as far as possible - there's only a few of them (see graph in #59234) and we should aim to make them more reliable in a safer way.