Ensure sleep on monitor_joypads thread #70099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure sleep is occurring during monitor_joypads() function to ensure thread is not busy.
|
@timothyqiu points out that if #70082 is the same freeze, then it is before #69563 was merged in 3.x, so maybe this is not the cause. Still suspicious though. 😁 |
|
We now think the while loop should run ok and only terminate on exit, so these two bits of evidence suggest this likely isn't the freeze, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure sleep is occurring during monitor_joypads() function to ensure thread is not busy.
May fix #69942
Notes
while (!monitor_joypads_exit.is_set()) {, which may be enough but I don't really know this bit of code.