Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circle emission shape with random and ordered emission mode #70200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisb123
Copy link

@chrisb123 chrisb123 commented Dec 17, 2022

Added a circle particle emitter and emission modes
See Proposal 5849 for more details
godotengine/godot-proposals#5849

image

With a circle emitter and ordered particle emission it is now possible to create patterns

2022-12-18.02-44-12.mp4

@chrisb123 chrisb123 requested review from a team as code owners December 17, 2022 16:09
@chrisb123 chrisb123 force-pushed the particles-random-circle branch 2 times, most recently from 75182a9 to c65c7a2 Compare December 17, 2022 17:13
@Calinou Calinou added this to the 4.0 milestone Dec 17, 2022
@clayjohn clayjohn modified the milestones: 4.0, 4.x Dec 17, 2022
scene/2d/cpu_particles_2d.h Outdated Show resolved Hide resolved
@KoBeWi
Copy link
Member

KoBeWi commented Dec 21, 2022

Like #70145, this needs to be in GPUParticles too.

@QbieShay
Copy link
Contributor

QbieShay commented May 1, 2023

Hey @chrisb123 ! Thank you for working on this. I think this is a good quality of life improvement, although it doesn't entirely addresses the linked proposal. I would prefer if the enum was generic enough to be reused for emission textures as well.

@chrisb123
Copy link
Author

I don't have time at the moment to work on this at the moment.
I haven't used emission textures or GPU particles, Im not sure what is required for either
Someone can takeover if they like, or it can wait until I have more time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs consensus
Development

Successfully merging this pull request may close these issues.

5 participants