Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to compiled GDScript in export #71752

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

vnen
Copy link
Member

@vnen vnen commented Jan 20, 2023

This feature was removed from GDScript so it should not be present on the interface nor in the saved export presets.

Closes #59241

Also removed mentions for encrypted scripts since those are obsolete now that you can encrypt any resource.

Note: The name of the feature may be misleading, since scripts are not "compiled" when this option was selected (in 3.x), it simply stores a binary version of the tokenized file (more details on the linked issue) that helps only a bit for faster loading. There's a plan to store actual compiled files on the exported project, which will be superior in many ways, but unfortunately will not be available in the 4.0 release.

This feature was removed from GDScript so it should not be present on
the interface nor in the saved export presets.
@vnen vnen added this to the 4.0 milestone Jan 20, 2023
@vnen vnen requested a review from a team as a code owner January 20, 2023 18:18
@akien-mga akien-mga merged commit 9891aea into godotengine:master Jan 20, 2023
@akien-mga
Copy link
Member

Thanks!

@vnen vnen deleted the no-gdc-export branch January 21, 2023 02:48
@vmtest888
Copy link

@vnen Will this patch be released in version 4.0.2?

@vmtest888
Copy link

What I mean is, can it be re-implemented in 4.0 if .gd is compiled into .gdc? Otherwise, pck is too insecure.

@YuriSizov
Copy link
Contributor

If it's ever re-implemented, it's not going to be in a patch release (e.g. 4.0.x).

@sepTN
Copy link
Contributor

sepTN commented Apr 23, 2023

Will this pull be implemented along with the upcoming 4.1 version?

@Calinou
Copy link
Member

Calinou commented Apr 23, 2023

This pull request is already merged in 4.0, since this was merged before master was branched out to 4.1 (which happened on 2023-03-01).

This part is still valid though, and not specifically planned for 4.1:

There's a plan to store actual compiled files on the exported project, which will be superior in many ways, but unfortunately will not be available in the 4.0 release.

See also godotengine/godot-proposals#6031, which is tangentially related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GDScript 2.0: .gdc bytecode files not created with export option
6 participants