[macOS/Windows] Add optional ANGLE backed OpenGL renderer support (runtime backend selection).

[bruvzg]

Same as #72475, but do not require separate ANGLE build.

ANGLE can be enabled and overridden for specific platform in the project setting or using --rendering-driver opengl3_angle command line argument.

[Riteo]

So does this supersede #72475?

Edit: Also, what's the advantage of having ANGLE on Windows?

[clayjohn]

So does this supersede #72475?

Edit: Also, what's the advantage of having ANGLE on Windows?

OpenGL drivers on Windows are all over the place. On many Windows devices OpenGL drivers are so bad that the driver itself produces regular stutters during gameplay.

[bruvzg]

So does this supersede #72475?

Yes, when it's finished.

Edit: Also, what's the advantage of having ANGLE on Windows?

Some Intel GPUs have much better DX support than OpenGL.

[akien-mga]

Code review on GitHub.

[akien-mga]

Might be worth moving to a separate PR so it can be cherry-picked. Also relevant to propagate in godot-cpp.

I assume this means /DEBUG:NONE is not the default option when no /DEBUG is specified?

[AThousandShips]

Just some minor comment nitpicks

[akien-mga]

Tested successfully on Windows 10 with https://github.com/team-godog/NGJ2023_Godog (after converting the game to GL Compat backend), compiling with VS 2022.

It seems to work well, both out of the box, and with the angle_libs path at compile time.

Out of the box, it uses ANGLE provided by Windows:

OpenGL API OpenGL ES 3.0.0 (ANGLE 2.1.18912 git hash: 872d7947bb76) - Compatibil
ity - Using Device: Google Inc. (AMD) - ANGLE (AMD, Radeon RX Vega Direct3D11 vs
_5_0 ps_5_0, D3D11-31.0.21029.1006)

With the static libs, it uses our own version:

OpenGL API OpenGL ES 3.0.0 (ANGLE 2.1.21553 git hash: 430a4f559cbc) - Compatibil
ity - Using Device: Google Inc. (AMD) - ANGLE (AMD, Radeon RX Vega Direct3D11 vs
_5_0 ps_5_0, D3D11-31.0.21029.1006)

Could be worse adding something to disambiguate so we can know easily in logs if we're using the system or bundled ANGLE, the only difference here seems to be the version / git hash.

Did some light testing on Linux, didn't spot regressions in the GL renderer.

[akien-mga]

Code looks good, and basic testing seems to show it works fine.

I still need to do some testing with MinGW to make sure it will work fine on the official build server.

[akien-mga]

Tested successfully on Windows 10 with team-godog/NGJ2023_Godog (after converting the game to GL Compat backend), compiling with VS 2022.

It seems to work well, both out of the box, and with the angle_libs path at compile time.

Out of the box, it uses ANGLE provided by Windows:

OpenGL API OpenGL ES 3.0.0 (ANGLE 2.1.18912 git hash: 872d7947bb76) - Compatibil
ity - Using Device: Google Inc. (AMD) - ANGLE (AMD, Radeon RX Vega Direct3D11 vs
_5_0 ps_5_0, D3D11-31.0.21029.1006)

With the static libs, it uses our own version:

OpenGL API OpenGL ES 3.0.0 (ANGLE 2.1.21553 git hash: 430a4f559cbc) - Compatibil
ity - Using Device: Google Inc. (AMD) - ANGLE (AMD, Radeon RX Vega Direct3D11 vs
_5_0 ps_5_0, D3D11-31.0.21029.1006)

So actually, with our static libs I get much worse performance on this demo compared to the system ANGLE.

With the Windows 10 builtin ANGLE, I get 140-160 FPS (vsync disabled), and with our static libs I get 75 FPS.

With native OpenGL, I get 400-430 FPS.

[akien-mga]

Thanks! Amazing work 🎉

[FyiurAmron]

for posteriority: a quick test can be done by placing e.g.

[rendering]
renderer/rendering_method="gl_compatibility"
gl_compatibility/driver.windows="opengl3_angle"

in the project.godot; regardless of #65541 I couldn't find driver selection settings in the editor's UI menus.

Also, FWIW, this (i.e. switching to ANGLE-based OpenGL renderer) actually fixes #60967 for me :)