-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename odd PathFollow2D/3D
methods
#72851
Rename odd PathFollow2D/3D
methods
#72851
Conversation
b3b8edf
to
9ba72ba
Compare
Renamed to <member name="cubic_interpolation" type="bool" setter="set_use_cubic_interpolation" getter="is_using_cubic_interpolation" default="true"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an active user of PathFollow* but this rename makes sense to me. We could merge for 4.0.
If we want this merged for 4.0, then it needs to handle the old property name with |
9ba72ba
to
9613c1e
Compare
@akien-mga added (I guess it was only the setter that broke the scene) |
9613c1e
to
c6094c8
Compare
Also added a getter for now. |
c6094c8
to
ea739fa
Compare
So actually I feel the better naming (and somewhat consistent with many other books) would be:
It's not perfect as it doesn't make clear that false means linear interpolation instead of no interpolation, but it's less awkward that "use" IMO. |
ea739fa
to
22c7bff
Compare
@akien-mga rrrenamed! |
22c7bff
to
30cb87c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not convinced by swapping the order of the words only for the getter (is_interpolation_cubic
). What I had suggested was set_cubic_interpolation
/is_cubic_interpolation_enabled
.
All in all, I find this change quite nitpicky and while I agree that cubic_interpolation
is a better property name than cubic_interp
(we try to avoid abbreviations), I think on the day of the RC1 release the ship has sailed for this kind of consistency renaming.
30cb87c
to
5827f74
Compare
@akien-mga Sorry, I was already tired and my mind didn't seem to be working😵💫 Here is my last rename. |
@akien-mga decided this was too late for 4.0RC, so it is merged into #72842 and this will be done in 4.1. |
These are inconsistent with other parts.