Improve GDScript identifier tokenization #73226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
force-pushed
the
gdscript_tok_improvement
branch
from
0c443fd
to
460c2e9
Compare
AThousandShips
force-pushed
the
gdscript_tok_improvement
branch
from
460c2e9
to
f68beeb
Compare
|
Pushed to 4.2 milestone, as this is an enhancement PR and as we're in 4.1 feature freeze. Though, as it seems to be a good one, I added it to the list of PRs to team review to not forget it. |
adamscott
approved these changes
Jul 10, 2023
YuriSizov
changed the title
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
potential_identifier()exit early if not ascii-only.Edit: Was unsure if the token being created before pushing errors was important, so kept that order.