Add get_tree_string and get_tree_string_pretty methods to Node to complement printing methods

[vPumpking]

Add two methods to Node class:

• get_tree_string that allows to return a string containing the tree in shape of a list
• get_tree_string_pretty that makes the same thing but in a more convenient shape.
  these methods complement the print_tree and print_tree_pretty methods.

proposal: godotengine/godot-proposals#6288

(succesfully works with the latest code)

[akien-mga]

Is there a feature proposal for this? https://github.com/godotengine/godot-proposals
We need one to gauge interest from the community in adding more core methods.

[vPumpking]

Is there a feature proposal for this? https://github.com/godotengine/godot-proposals We need one to gauge interest from the community in adding more core methods.

yes it is: godotengine/godot-proposals#6288

[jmb462]

Old _print_string_pretty method code is now redondant. You should call your new method inside public print_tree_pretty() to prevent duplicating logic, then _print_string_pretty will also not used anymore and should be removed.

Same thing with the not pretty methods.

[vPumpking]

Old _print_string_pretty method code is now redondant. You should call your new method inside public print_tree_pretty() to prevent duplicating logic, then _print_string_pretty will also not used anymore and should be removed.

Same thing with the not pretty methods.

yes but doing that will make my PR destructive and less easy to approve

[vPumpking]

Old _print_string_pretty method code is now redondant. You should call your new method inside public print_tree_pretty() to prevent duplicating logic, then _print_string_pretty will also not used anymore and should be removed.
Same thing with the not pretty methods.

yes but doing that will make my PR destructive and less easy to approve

ok no I understand what you means
I will maybe make it

[vPumpking]

@akien-mga excuse me, can you relaunch the workflow verifications please? Yesterday I have commited my repository and it has stopped the verification.

[akien-mga]

I would suggest squashing the commits first, as 12 commits is unnecessary for such a change.
See PR workflow for instructions.

[vPumpking]

I would suggest squashing the commits first, as 12 commits is unnecessary for such a change. See PR workflow for instructions.

i will make that this afternoon

[vPumpking]

I would suggest squashing the commits first, as 12 commits is unnecessary for such a change. See PR workflow for instructions.

here we go
squashing finished!

[vPumpking]

@akien-mga so now can you relaunch the workflows please?

[vPumpking]

someone has an idea on why it doesn't work with the linux mono editor?

[vPumpking]

ok yeah oops I forgot to update the Node doc
it will be made in minute

[vPumpking]

finally all is in order.
sorry for all the time I took to mainteners,
the PR is now fully ready to be verified with the workflows. It may not push any error.

[vPumpking]

what?! is there a place where I can read all the conditions to verify to be successfully checked?

[vPumpking]

I will rewrite the method references and verify it with make rst so as to have finally something that works with the workflows and to be merged.
Another time so sorry for the time that I spend to mainteners.

[vPumpking]

the fail was in the fact that alphabetical order was not respected.
Now, the commit is truly ready to be run with workflows. I used the make rst command to verify it.
Finally.

[vPumpking]

why doesn't it work?!

[Calinou]

why doesn't it work?!

You have an extraneous blank line in the doc/classes/Node.xml class reference XML. There must be no blank lines in class reference files.

I recommend running path/to/godot.binary --doctool locally in the Godot repository root, so you can spot those errors earlier. See Contributing to the class reference for more information.

[vPumpking]

I think it's fixed up
thanks @Calinou

[vPumpking]

Sorry, I accidentally renamed the branch used by this PR, so now the PR is here: #77072
Can you rewrite the labels and topics please?