Reorganize context menu in FileSystem dock to put more used options higher

[YuriSizov]

So during these last few weeks I've been using the editor quite a lot to test various PRs and reports, and was constantly feeling awkward about the position of the "New" context menu item in the FileSystem dock.

For some reason, it's at the bottom while I expect useful items to be at the top. So it always takes a bit of time to scan the context menu from the top to find it. I started to get used to it, but I don't think that this position ideal, or makes sense. There is an argument to be made that this matches File Explorer in Windows (and maybe similar tools on other platforms), but that's not a great comparison IMO. A better comparison is a code editor or an IDE, a professional creator's tool that operates on a "project". So, for example, in VS Code "New" items are at the top of the list, and it feels very intuitive.

At the same time, an arguably less useful option, "Add to Favorites" (and its "Remove" counterpart) are located very high, always getting in the way.

Additionally, folders have this "Open" option which only expands selected folders, and it's located in the middle. At the same time we have "Expand/Collapse All" at the top (for a single folder). So it felt very natural for the "Open" option to be renamed to "Expand" and put to the top, next to its cousins.

Overall, the new context menu for a folder looks like this:

I think it's very reasonable like that, and provides quicker and more intuitive access to the most used items.

---

Interestingly, single items also have the "New" menu option available, likely to make it easier to create new items in their parent folder. Not all apps do that, but I didn't want to change any functionality, so I kept it as is. That means, however, that the new position of this item is in between various file options. But I don't think it's too bad. The "New" option should be high, as I established above, so it wouldn't make sense to move it anywhere else.

---

The menu you see when clicking on an empty space is exactly as it was. When you have multiple items selected, the menu is only slightly different:

---

As mentioned, some renames were made for clarity and consistency (items describe actions). Some icons were also adjusted. This PR also does a bit of a clean-up in the relevant FileSystem dock code.

As a closing note, I fully expect this to be controversial, but I think it makes more sense this way, and is in line with what is expected from such tools. There was a bit of support in the contributors chat to these ideas, so I'm hoping we can merge it quickly.

[fire]

As part of the usability team I like this. @SaracenOne any thoughts?

[vonagam]

My only nitpick is that it could have gone further - why isn't "Create New" a first item? "Expand" you can already do with a left click to the right of a folder name, "Expand All"/"Collapse All" - definitely used less often then creating new folder or scene or script.

Let's look at other IDEs, game engines and systems when it comes to context menu for a folder:

1. VSCode (as mentioned in PR) "New File" and "New Folder" - first items.
2. JetBrains products - "New" or "Add" - first context item.
3. Sublime Text - "New File" - first.
4. Unity - "Create" - first.
5. Unreal Engine - "New Folder" and "New (Something)" - at the very top.
6. MacOS - "New Folder" - first option when clicked inside a folder.
7. Linux - depends, but for Ubuntu, for example, first options are "New Folder" and "New Document".

So, why should Godot differ from those in that regard?

[YuriSizov]

@vonagam As I mentioned on RC, the more changes I add, the more opportunities to die to bikeshedding this PR has :) The central and bottom part of the context menu is consistent between folders and files. So it kind of makes sense to keep the differences at the top. I think it's pretty easy to filter out the expand options if those are not what you're looking for.

Also "Expand" is different from using the tree, because it applies to multiple folders. Otherwise it would be very much redundant.

PS. A follow-up PR is possible anyway if we agree on this and want to do further changes.

[Structed]

I am also confused why it's not the very first option. I see your point @YuriSizov you're afraid of this not getting merged fast enough, but perhaps it's not as controversial as you thought 😂

Anyways, I like any improvement in that area because, just like you, I am always looking for the "New " item.

[ygypt]

Making it the absolute first item would also solve the issue of the Create New submenu being between options when right clicking a File :)

[MangoDragonHub]

I really like this idea of having submenus in the editor. However, I would move up Resource above Scene since most of the labels are alphabetic.

[YuriSizov]

@ygypt For the file's context menu having the New item at the top doesn't make sense. It's not the most important option when right-clicking files. Luckily, moving Expand options for folders elsewhere is not going to affect files, so it's all good.

---

I do however think that having a pretty similar bottom half is an okay middle ground. But if there is indeed no controversy, I can move Expand options.

[YuriSizov]

Okay, by popular demand...

[YuriSizov]

The time has come 🙃