Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Add option to disable exporting debug symbols #73939

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos commented Feb 25, 2023

Marked as draft since it depends on #72895 which should be merged first. Already merged.

@raulsntos raulsntos added this to the 4.x milestone Feb 25, 2023
@raulsntos raulsntos force-pushed the dotnet/export-symbols branch from 267f89b to 385e64d Compare June 2, 2023 14:27
@raulsntos raulsntos marked this pull request as ready for review June 2, 2023 14:28
@raulsntos raulsntos requested a review from a team as a code owner June 2, 2023 14:28
- Add export option to configure if the exported game should include debug symbols (PDB).
- Remove unused `outputDir` local variable.
- Replace `Process.GetCurrentProcess().Id` with `System.Environment.ProcessId` (CA1837).
@raulsntos raulsntos force-pushed the dotnet/export-symbols branch from 385e64d to 0aa1f34 Compare June 2, 2023 14:38
Copy link
Member

@RedworkDE RedworkDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected.

(Personally I prefer using True/False for MSBuild things, but the existing code already uses the lowercase version, so it is good as-is)

@akien-mga akien-mga modified the milestones: 4.x, 4.1 Jun 9, 2023
@akien-mga akien-mga added the bug label Jun 9, 2023
@akien-mga akien-mga merged commit 5047892 into godotengine:master Jun 9, 2023
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/export-symbols branch June 9, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C# Mono release builds contain debug info (PDB)
3 participants