-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abort on startup with a visible alert if required Vulkan features are missing #73999
Abort on startup with a visible alert if required Vulkan features are missing #73999
Conversation
5787add
to
2a146f9
Compare
Amazing! Does this work on mobile devices as well? |
At least on Android |
I just tested and it's not blocking on iOS either.
Causes a crash before the alert is visible on screen, so I assume it would be the same in this case of the alert about required vulkan features. |
Given the current situation that on mobile alert() isn't blocking, perhaps a compromise could be to simply not crash/exit on mobile. As I understand it that would leave it at a black screen once the user closes the alert message with the info, but that's fine and much better than the alternative (crash with no explanation) or current situation (black screen with no explanation). |
2a146f9
to
eece2b3
Compare
I removed the |
I think this still needs to return |
eece2b3
to
70cd272
Compare
Done 🙂 I've also modified the dialog to mention the GPU model name (useful for systems with multiple GPUs to choose from). |
70cd272
to
a9d0862
Compare
Tested locally and this seems to work fine now. The popup works as expected and then falls back to the normal "failed to initialize vulkan" error which points the user to using the compatibility renderer. |
a9d0862
to
e65d2d7
Compare
e65d2d7
to
ce57c23
Compare
Thanks! |
See #70013 (comment).
Preview