[DisplayServer] Implement screen_get_pixel method for LinuxBSD/X11, macOS and Windows.
#74087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
bruvzg
force-pushed
the
get_screen_px
branch
from
584082c
to
184bd09
Compare
…acOS and Windows.
akien-mga
approved these changes
Mar 2, 2023
|
Thanks! My understanding would be that this feature could be used to fix #74048 properly? |
|
Love this method! |
nikitron
reviewed
Mar 8, 2023
Comment on lines
+645
to
+650
| HDC dc = GetDC(0); | ||
| COLORREF col = GetPixel(dc, p.x, p.y); | ||
| if (col != CLR_INVALID) { | ||
| return Color(float(col & 0x000000FF) / 256.0, float((col & 0x0000FF00) >> 8) / 256.0, float((col & 0x00FF0000) >> 16) / 256.0, 1.0); | ||
| } | ||
| ReleaseDC(NULL, dc); |
There was a problem hiding this comment.
Why we don't call ReleaseDC(...) if the color is valid?
And why we don't check that GetDC(0) is not NULL?
There was a problem hiding this comment.
If not wrong, window's style class uses CS_OWNDC flag, meaning the DC is unique and shared for all drawing operations.
akien-mga
changed the title
screen_get_pixel method for LinuxBSD/X11, macOS and Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds function to get screen pixel color. A base for better
ColorPickereyedropper implementation.