ItemList: Clarify distinction between disabled and selected in sending signals #74250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @KoBeWi could I request a review from you, or @akien-mga could you add anyone as a reviewer whom you might think would be able to review this PR? |
YuriSizov
reviewed
Mar 21, 2023
YuriSizov
reviewed
Mar 21, 2023
YuriSizov
reviewed
Mar 21, 2023
akien-mga
changed the title
KoBeWi
approved these changes
Jun 30, 2023
…g signals disabled -> not sending any signal at all (activated, selected, deselected, ...) selected -> only possible when not disabled, and when selectable Fixes godotengine#74086.
akien-mga
changed the title
akien-mga
force-pushed
the
bugfix-selection-signals-when-disabled-or-not-selectable
branch
from
7732bf6
to
fa63107
Compare
|
OP was no longer responsive, so I went ahead and fixed the style issues myself. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made sure there is a clear distinction in which situations signals are triggered:
when item is disabled: send no signal at all for this item (activated, selected, deselected, ...)
when item is selectable: send signals (item_selected, multi_selected) when not disabled.
when is activated now triggered? When item is not disabled and double clicked (pressing enter is only possible when selectable 😄 )
I am in conflict with deselecting however, I am allowing deselection even when selectable is turned off to keep this behaviour as before.
Fixes: #74086