Allow reducing SplitContainer drag bar thickness using the default themes #74691
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The grabber handles of SplitContainers have some white space around, making them 8px thick although the actual draw area is 2px wide only. Due to a minimum size enforcement based on the grabber graphic size, it is impossible to have a splitter thinner than 8px without providing an alternate grabber graphic. I discovered this when experimenting with the Godot theme to have thinner separators between panels. This fixes both the default and editor themes. The default splitter bar size is still 8px, making sure nothing is changed in the default appearance. But it can now be reduced down to 2px without the need to provide an alternate graphic. Useful in a project where I need very thin separators, and in building a compact theme for Godot. The minimum grab thickness property already makes sure it is easy to grab the splitter with the mouse with some extra pixels of allowance. Experimenting with the editor unveiled an issue in the alignment of the T-shaped center grabbers on the 3D editor, when the view is split in 3. This commit also fixes this point, simplifying the approach by centering the grabber graphics in all cases. The whitespace is adjusted on those T-grabbers in consequence. Compatibility with 3.x: to verify. Needs adjustement to the 3.x default theme graphics.
|
Need this feature, any update info? |
|
#87085 changed the editor v and h splitter icons, but not the 3-way or the default theme ones. |
|
The edited SVG files are invalid and don't load in editor. |
|
I need to have a look as there have been major changes to the theme system since I proposed this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the default themes, the grabber handles of SplitContainers have some white space, making them 8px thick although the actual drawn area is 2px wide only.
Due to a minimum size enforcement based on the grabber graphic size, it is impossible to have a splitter bar thinner
than 8px without providing an alternate grabber graphic.
I discovered this when experimenting with the Godot theme to have thinner separators between panels.
This fixes both the default and editor themes.
The default splitter bar separation remains 8px to avoid breaking changes. But it can now be reduced down to 2px without the need to provide an alternate graphic.
Experimenting with the editor unveiled an issue in the alignment of the T-shaped center grabbers on the 3D editor.
Happens when the view is split in 3 and the separation is something else than 8px.
This commit also fixes this point, simplifying the approach by centering those specific grabber graphics in all cases and adjusting the whitespaces in the graphics.
Compatibility with 3.x: needs adjustement to the 3.x default and editor themes.