Windows: Ask user before permanently deleting files with move_to_trash
#75023
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #74678 and the question why the Documents folder did not end up in the trash. (I tried in a VM and was surprised to find that windows does nothing to prevent you from doing this, not even when using the explorer; tho I found the folder in the trash just fine there)
Makes windows pop up this confirmation dialog when recycling items that are too large for the trash (by default more than 5% of the disk size):
It is still possible to disable the recycling bin entirely for a disk, i which case the items will always be deleted permanently without a confirmation dialog (from the OS)