Expose 'Reimport' on right-click context menu in the FileSystem panel

[nongvantinh]

Implement proposal: #6320

Bugsquad edit:

• Closes Expose 'Reimport' on right-click context menu in the FileSystem panel godot-proposals#6320

[KoBeWi]

_reimport_attempt() for multiple files will reimport all files with the same type as the first selected file. You can e.g. select texture and audio file and clicking Reimport will trigger the warning about changing import type. If you accept, it will corrupt the imported files.

Either the function needs to be changed or _reimport() shouldn't appear if there is more than 1 type of resources selected.

[nongvantinh]

I understand. I tested the import tab in the current version and found that when I try to import two different file types, the editor doesn't let me reimport them. To maintain consistency, I'll try to implement the same functionality as the editor.

[KoBeWi]

The implementation can be much simpler:

bool resource_valid = true;
String main_extension;

for (int i = 0; i != p_paths.size(); ++i) {
	String extension = p_paths[i].get_extension();
	if (extension_list.has(extension)) {
		if (main_extension.is_empty()) {
			main_extension = extension
		} else if (extension != main_extension) {
			resource_valid = false;
			break;
		}
	} else {
		resource_valid = false;
		break;
	}
}

[akien-mga]

Seems useful.

[akien-mga]

Thanks!

[dogboydog]

Hey, thank you very much for implementing this! Cool to see a proposal I made actually make it in!

just tried this in the 4.2 dev3 snapshot. It seems like this doesn't work for all types? For instance, when using the https://github.com/Kiamo2/YATI plugin, .tmj files don't show Reimport

This was actually the use case that I created the proposal for, to reimport my tilemaps easily. Another plugin I'm using, that I wrote myself, does have the Reimport option

Any idea why it wouldn't show up for some resources?

[KoBeWi]

Maybe there is something wrong with the YATI implementation, like missing function or something. Doesn't it print any errors when used? Can you show the code of your plugin?

[dogboydog]

I don't think I have errors from YATI but I can check later. This is my importer code which does show Reimport:

https://github.com/dogboydog/YarnDonut/blob/godot4/addons/YarnDonut/Editor/YarnImporter.cs

[KoBeWi]

YATI returns "Node2D" in GetResourceType(), while the method expects Resource type. I think it should be PackedScene in this case.

[dogboydog]

Thanks, I'll let the developer know. Edit: confirmed that was the issue, thank you