GDScript: Show script errors from depended scripts #75216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay, rune is back!!! 🥇 |
adamscott
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Seems fine on the GDScript side. Works well too!
@Paulb23 and @YeldhamDev, what do you think of that PR?
|
Would be good to do a rebase against the current master before we merge this. |
YuriSizov
force-pushed
the
rune-dependancy-errors
branch
from
7c8a137 to
83b0170
Compare
YuriSizov
approved these changes
Jul 24, 2023
|
Thanks! |
YuriSizov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds errors of depended scripts to error list
makes it easy to go right to the source of a dependency error
particularly useful for the rare times when the gdscript compiler bugs and fails compilation only when a script is used as a dependency
Screenshot:
