-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure binds are duplicated with Node
signals
#75382
Conversation
69a1b3b
to
97a7aa1
Compare
Unbinds have the same problem. |
Will look into it as well, thank you |
97a7aa1
to
9cf13ce
Compare
Update: To do:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it respect CONNECT_REFERENCE_COUNTED and skip the check for already bound in the target?
I think the method is always called on freshly duplicated nodes, so it doesn't matter.
Should the variant array be duplicated?
If you mean the array from get_bound_arguments()
, the method always returns a new Array.
Meant if the duplicated node has multiple signals connected, this will connect only the first one, but can be discussed in a follow-up |
Thanks! |
Thank you! |
Cherry-picked for 4.1.4. |
Also added a check to ensure the function has a method name, doesn't fully prevent pointer binds from ending up attempting to duplicate (it would be an error to have such a signal as persists anyway), could make a more elaborate change involving adding a
rebind
function toCallable
but think it is outside the scope of thisFixes #75105