Update GPUParticles2D/3D speed scale on ENTER_TREE #75398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you check if the same issue occurs with GPUParticles3D? There's a fair chance it's impacted by the bug mentioned in #75218. |
Good point. Will do. |
Fix for godotengine#75218 Pause notifications are not sent when a node is added as a child. So GPUParticles2D should also obey its can_process status on ENTER_TREE, not just PAUSED/UNPAUSED.
newobj
changed the title
|
Updated w/ fix for GPUParticles3D as well. (cc: @Calinou) I squashed my commit for GPUParticles3D then pushed. Was that good for the workflow? Or should I have pushed an additional commit into my branch? Thanks, let me know. |
Yes. |
KoBeWi
approved these changes
Mar 27, 2023
Calinou
approved these changes
Mar 28, 2023
|
Thanks! And congrats on your first merged pull request! |
|
Cherry-picked for 4.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75218
Pause notifications are not sent when a node is added as a child. So GPUParticles2D/3D should also obey its can_process status on ENTER_TREE, not just PAUSED/UNPAUSED.
Warning: This is my first PR for Godot :)
For GPUParticles2D:
Before:
Particles when running scene w/ disabled parent + inherit
After:
No particles when running scene w/ disabled parent + inherit
For GPUParticles3D:
Before:
Running, ignoring inheritance of disabled:
After:
Running, obeying inheritance properly: