Fix recursive Node.find_children

[kleonc]

In Node.find_children method when the name of a child node was not matching the passed in non-empty pattern it resulted in not reaching if (recursive) block because of the continue to the next iteration:

godot/scene/main/node.cpp

Lines 1417 to 1419 in 23394be

	if (!p_pattern.is_empty()) {
	if (!cptr[i]->data.name.operator String().match(p_pattern)) {
	continue;

This PR fixes this logic to always get to the if (recursive) block so no children will be unintentionally skipped.

Fixes #75446. Fixes #63757.

Supersedes #63785.

[hawkerm]

@kleonc does this PR need anything else like a test or something before it can be reviewed? Anything I can do to help?

[kleonc]

@kleonc does this PR need anything else like a test or something before it can be reviewed? Anything I can do to help?

It can be reviewed as is (feel free to do so). But I guess I could add some test case with nested nodes for find_children, won't hurt. 🙃

[Maran23]

And this may supersedes #63785 and therefore fixes issue #63757 as well?

[kleonc]

And this may supersedes #63785 and therefore fixes issue #63757 as well?

@Maran23 Yeah, it should fix #63757 as well. But it doesn't change anything for the nodes without an owner, gonna fix this in here too. Actually, reading the in-docs description for the owned parameter:

godot/doc/classes/Node.xml

Line 241 in de416c5

If [param owned] is [code]true[/code], this method only finds nodes who have an assigned [member Node.owner]. This is especially important for scenes instantiated through a script, because those scenes don't have an owner.

I think ignoring whole subtrees for the nodes without an owner is intentional. Otherwise (by not ignoring the whole subtree like in #63785) the children of the dynamically instantiated scenes would still be checked, only the root nodes of such scenes would be ignored. Changing this behavior seems like a compat breaking change to me, hence I'll leave it as is. Could always be tweaked in another PR (if it's actually not intended).

[akien-mga]

Thanks!