Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GLES3 GPUParticles3D not working in HTML export #75795

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Fix GLES3 GPUParticles3D not working in HTML export #75795

merged 1 commit into from
Apr 12, 2023

Conversation

cody82
Copy link
Contributor

@cody82 cody82 commented Apr 7, 2023 •
edited by YuriSizov
Loading

This fixes issue #75270

I replaced switch with if and it works for me.

For 3.x this fix is not needed. I only encountered this on the 4.0 branch.

Production edit: Fixes #75270

@cody82 cody82 requested a review from a team as a code owner April 7, 2023 20:44
@AThousandShips
Copy link
Member

The else if should be placed on the same line as the closing bracket like so } else if

@cody82
Copy link
Contributor Author

cody82 commented Apr 7, 2023

Fixed

@Calinou Calinou added this to the 4.1 milestone Apr 7, 2023
clayjohn
clayjohn approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@akien-mga akien-mga merged commit 6a6e36e into godotengine:master Apr 12, 2023
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.3.

@The-Randalorian The-Randalorian mentioned this pull request Apr 26, 2023
Closed
@akien-mga akien-mga changed the title Fix "error X3708: continue cannot be used in a switch" in HTML export Fix GLES3 GPUParticles3D not working in HTML export Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug platform:web topic:particles topic:rendering
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

GPUParticles2D not emitted in web export
6 participants
@cody82 @AThousandShips @akien-mga @YuriSizov @clayjohn @Calinou