Split editor-specific import metadata for textures #75949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaracenOne
approved these changes
May 25, 2023
|
I'd suggest a rebase for good measure (last rebase over a month ago), then it can be merged. |
YuriSizov
force-pushed
the
import-split-texture-meta
branch
from
7987b8b
to
b856188
Compare
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue right now is that we need to store current values of editor settings for comparison, so we can invalidate the imported texture and reimport it. I used the
*.importfile, where we already store some metadata and for which we have the necessary scaffolding to read and write.Unfortunately, this was a bad idea, as the values are of course different for different users and systems, and storing them like I did introduces unnecessary changes to the
*.importfile, which should be system-independent, and which is included into version control.So this PR addresses the issue by splitting these editor-specific metadata properties from the rest and storing them in the
.godot/importedfolder, alongside the texture itself. The file is created and loaded only if you import a texture for editor use. Existing projects will receive an error, urging them to reimport the file. I could've added some fallback logic to read from the old place just in case, but I think it's better to just reimport the texture and be done with it.