Don't store instance transform origin in RD 3D renderer unless requested #76003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when using doubles builds of the engine, instance transform was stored no matter what which caused world space particles to accumulate the instance transform twice
akien-mga
approved these changes
Apr 12, 2023
|
Thanks! |
|
Cherry-picked for 4.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #75549
Supercedes: #75788
GPUParticles3D that use world space disable the
store_transform_cacheproperty to ensure that the instance transform is not used in the scene shader (it is set to 0,0,0 and the transform comes from the particle). When using doubles builds we ignored this flag and stored the transform origin and precision property regardless of the value ofstore_transform_cache.store_transform_cacheistruefor every other instance type, so this only affects GPUParticles3D that have local coordinates set to false (it is set to false by default)