Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an example on how to use ImmediateMesh #76470

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

MewPurPur
Copy link
Contributor

@MewPurPur MewPurPur commented Apr 26, 2023

Adds a small code snippet on how to use ImmediateMesh and links to our tutorial for further information. Also links the Expression class to its tutorial.

@MewPurPur MewPurPur requested a review from a team as a code owner April 26, 2023 10:03
@@ -4,9 +4,19 @@
Mesh optimized for creating geometry manually.
</brief_description>
<description>
Mesh optimized for creating geometry manually, similar to OpenGL1.x immediate mode.
A mesh type optimized for creating geometry manually, similar to OpenGL1.x immediate mode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can mention that this is similar to ImmediateGeometry from Godot 3. That would make this class show up in the docs search results if people are looking for the old node. Though I can understand if references to old equivalents aren't wanted in the docs.

Copy link
Contributor Author

@MewPurPur MewPurPur Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other opinions? We don't have this for any classes currently, so I haven't added it - but I could. Personally I think it would be better to have some sort of mechanism for helping people find renamed classes, than to add it to the raw text everyone will read.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with not adding it for now, I think this is worth more discussion and shouldn't block this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we thought about adding a system to use the renames from the Godot 3 to 4 project converter to work as aliases when searching the docs.

Copy link
Contributor

@winston-yallow winston-yallow Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea, is that tracked somewhere so this can be added to the list? It's not really a rename though, it also changed from being it's own Node to being a resource for MeshInstances

@akien-mga akien-mga merged commit 6bf94cf into godotengine:master Apr 26, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.3.

@MewPurPur MewPurPur deleted the add-immediate-mesh-example branch April 26, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants