-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility breakage from adding NoiseTexture3D #76557
Conversation
b320e9d
to
c521d2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't do an in depth review, but the overall changes seem sensible, and undoing the compat breakage is great.
This looks awesome! I wanted to change as little as possible in the current implementation, and now I see that it was unnecessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on the MRP linked in #76486, it works.
Should be good to merge after applying suggestions.
3b1fd0b
to
6990950
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Unfortunately I haven't had the time to review the original PR, but this definitely looks like a sensible fixup/cleanup. Tested it and it looks like everything is still working fine.
Also optimize some of the Noise methods
6990950
to
ccff245
Compare
note that "Depth" and the like are common names for parameters involving z axis |
Thanks for fixing this up! 🎉 |
Follow up to #76486
#76486 broke compatibility by introducing a new parameter to
Noise.get_image()
andNoise.get_seamless_image()
. The new parameter was calledp_depth
even though the function did not return a 3D image (i.e. an array of Images), so it really represented a z offset.This PR introduces a
get_image_3d()
for use with 3D textures and it abstracts the oldget_image()
into an internal function_get_image()
which handles both 2D and 3D.This PR also:
Finally, I have left the seamless generation algorithm the same. Although I suspect it can be generalized to the 3D case a bit more and optimized.