Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Skip codespell check if CHANGED_FILES is empty #76903

Merged
merged 1 commit into from
May 10, 2023

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented May 10, 2023

This can happen when only thirdparty files are changed, since we grep them out. Re-add bin and thirdparty to the skip list for good measure.

Follow-up to #76828 and #76842.

Tested successfully with akien-mga#14, a change to only thirdparty/README.md properly skips the codespell step.

This can happen when only thirdparty files are changed, since we grep them out.
Re-add `bin` and `thirdparty` to the skip list for good measure.
@akien-mga akien-mga added this to the 4.1 milestone May 10, 2023
@akien-mga akien-mga requested a review from a team as a code owner May 10, 2023 07:45
@akien-mga akien-mga merged commit bee96aa into godotengine:master May 10, 2023
@akien-mga akien-mga deleted the ci-codesp-hell branch May 10, 2023 08:29
@akien-mga
Copy link
Member Author

Cherry-picked for 4.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant