Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript: Fix validate_call_arg() for unresolved datatype #77091

Merged
merged 1 commit into from
May 15, 2023

Conversation

dalexeev
Copy link
Member

Fix wrong implication.

#0  GDScriptAnalyzer::is_type_compatible (this=0x7fffffffca30, p_target=..., 
    p_source=..., p_allow_implicit_conversion=true, p_source_node=0x0)
    at modules/gdscript/gdscript_analyzer.cpp:4969
#1  0x0000555558c7f359 in GDScriptAnalyzer::validate_call_arg (
    this=0x7fffffffca30, p_par_types=..., p_default_args_count=0, 
    p_is_vararg=false, p_call=0x55557dddd570)
    at modules/gdscript/gdscript_analyzer.cpp:4843
#2  0x0000555558c6fb97 in GDScriptAnalyzer::reduce_call (this=0x7fffffffca30, 
    p_call=0x55557dddd570, p_is_await=false, p_is_root=true)
    at modules/gdscript/gdscript_analyzer.cpp:3095

Closes #77066.

@dalexeev dalexeev requested a review from a team as a code owner May 15, 2023 08:20
@akien-mga akien-mga added this to the 4.1 milestone May 15, 2023
@dalexeev dalexeev force-pushed the gds-fix-validate-call-arg branch from 9db54f6 to 7da3110 Compare May 15, 2023 09:14
@akien-mga akien-mga merged commit 5adac3c into godotengine:master May 15, 2023
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the gds-fix-validate-call-arg branch May 15, 2023 12:17
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser bug when trying to access attribute inside method call with variant type argument
3 participants