Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transfer of messages between queues #77093

Merged
merged 1 commit into from
May 15, 2023
Merged

Fix transfer of messages between queues #77093

merged 1 commit into from
May 15, 2023

Conversation

RandomShaper
Copy link
Member

No description provided.

@RandomShaper RandomShaper added this to the 4.1 milestone May 15, 2023
@RandomShaper RandomShaper requested a review from lyuma May 15, 2023 09:53
@RandomShaper RandomShaper requested a review from a team as a code owner May 15, 2023 09:53
lyuma
lyuma approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@lyuma lyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. These are the only two memcpy calls in core/object.

This should ensure both the void* arguments passed are the uint8_t[] buffers, not the Page* objects themselves as it was before.

@akien-mga akien-mga merged commit 5c653c2 into godotengine:master May 15, 2023
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_mq_copy branch May 15, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyuma lyuma lyuma approved these changes

Assignees
No one assigned
Labels
bug crash topic:core
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@RandomShaper @akien-mga @lyuma