Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript: Fix calling static func from non-static is allowed #77151

Merged
merged 1 commit into from
Jun 13, 2023
Merged

GDScript: Fix calling static func from non-static is allowed #77151

merged 1 commit into from
Jun 13, 2023

Conversation

dalexeev
Copy link
Member

Fix the regression from #76264 reported in godotengine/godot-proposals#6897 (comment).

@dalexeev dalexeev requested a review from a team as a code owner May 17, 2023 07:26
@dalexeev dalexeev mentioned this pull request May 17, 2023
Closed
@akien-mga akien-mga added this to the 4.1 milestone May 17, 2023
anvilfolk
anvilfolk approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@anvilfolk anvilfolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me! It seems to add a missing check for whether the function exists within a static context or not, instead of, I assume, using the static context of the previous function. Also contains the code to return to the previous context :)

adamscott
adamscott approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @anvilfolk. It's ready to merge.

@akien-mga akien-mga merged commit eb86dab into godotengine:master Jun 13, 2023
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the gds-fix-call-static-from-non-static branch June 13, 2023 16:55
@dalexeev dalexeev mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

@anvilfolk anvilfolk anvilfolk approved these changes

Assignees
No one assigned
Labels
bug regression topic:gdscript
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@dalexeev @akien-mga @adamscott @anvilfolk