Fix for Clang dev_mode Windows build #77165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a fix / workaround for
dev_mode
(all warnings and warnings as errors) build when building for Windows using Clang. Seems like a Clang issue, GCC apparently doesn't enable these warnings for-Wall
.Alterantively, we could maybe add
-Wno-missing-field-initializers
and-Wno-missing-braces
when building with Clang to avoid these in the future, but this is probably a pretty rare issue.Clang error: