Avoid error spam on first opening of a not yet imported project #77276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Omg I've been waiting for this since 3.0 alpha days... You rock! 🎉 |
|
I gave it a try, and it seems to work great! I did get spam of this error: but I don't think it's related to this PR. |
akien-mga
approved these changes
May 22, 2023
akien-mga
added
cherrypick:4.0
cherrypick:3.x
|
Thanks! 🎉 🥳 |
|
Cherry-picked for 4.0.4. This is a pretty important usability fix to miss out on, but we should also be ready to revert the pick in case this compromises existing projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@akien-mga, I have the impression that you will especially appreciate this one.
Besides, this affects every dependency collection operation started by the
EditorFileSystem, so maybe there are some cases where the error shouldn't be silenced. In any case, I can't think of a situation where they would be missed much.