Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose ProjectSettings.set_as_basic() to scripting #77417

Merged
merged 1 commit into from
May 25, 2023
Merged

Expose ProjectSettings.set_as_basic() to scripting #77417

merged 1 commit into from
May 25, 2023

Conversation

winston-yallow
Copy link
Contributor

This makes it possible to set custom properties as basic. Closes godotengine/godot-proposals#6938

@winston-yallow winston-yallow requested review from a team as code owners May 24, 2023 02:50
aaronfranke
aaronfranke reviewed May 24, 2023
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea, and it also serves as documentation for what a basic setting is.

doc/classes/ProjectSettings.xml Outdated Show resolved Hide resolved
@aaronfranke aaronfranke added this to the 4.x milestone May 24, 2023
@winston-yallow winston-yallow force-pushed the support-project-settings-usage-flags branch from 50faa4e to 263aedc Compare May 24, 2023 11:28
@akien-mga akien-mga modified the milestones: 4.x, 4.1 May 25, 2023
@akien-mga akien-mga merged commit 4c4bf58 into godotengine:master May 25, 2023
@akien-mga
Copy link
Member

Thanks!

@winston-yallow winston-yallow deleted the support-project-settings-usage-flags branch May 31, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfranke aaronfranke aaronfranke approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Expose method to set a project setting as basic
3 participants
@winston-yallow @akien-mga @aaronfranke