Fix incorrect value returned by HTTPClient.get_response_body_length on Web (reverted)
#77648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhilbrunner
approved these changes
May 30, 2023
YuriSizov
changed the title
HTTPClient.get_response_body_length() incorrect on WebHTTPClient.get_response_body_length on Web
|
Thanks! |
|
We should make sure @Faless gives this a glance too, and consider whether its important enough to backport the fix to 4.0 |
This was referenced Jul 20, 2023
YuriSizov
changed the title
HTTPClient.get_response_body_length on WebHTTPClient.get_response_body_length on Web (reverted)
|
The change was effectively reverted by #79846. It looks like we can't reliably compute the size of the body on the web platform due to browser limitations. So the value of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #77642