Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel tooltip when mouse leaves viewport #77933

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jun 6, 2023

Fixes #48634
Supersedes #49015

The issue is not so much about focus, but the fact that the tooltip will still appear when cursor moves out of viewport or even when another window appears on top. Example:

godot_SnhNIrrtUm.mp4

This PR fixes it.

@KoBeWi KoBeWi added this to the 4.1 milestone Jun 6, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner June 6, 2023 23:00
Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and it solves the issue for me. Implementation makes sense.
The introduced cancel-tooltip call will be made redundant by #67791, which overhauls the complete mouse-enter/mouse-exited system.

@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the do_not_the_tooltip branch June 7, 2023 09:50
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window unfocus doesn't stop tooltips from appearing
4 participants