Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CanvasItem::draw_string_outline parameter order #78010

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Fix CanvasItem::draw_string_outline parameter order #78010

merged 1 commit into from
Jun 8, 2023

Conversation

Sauermann
Copy link
Contributor

Switch p_font_size with p_size in header, because in all other locations, p_font_size comes before p_size.

@Sauermann
Fix CanvasItem::draw_string_outline parameter order
302a10e 
Switch `p_font_size` with `p_size` in header, because in all
other locations, `p_font_size` comes before `p_size`.
@Sauermann Sauermann requested a review from a team as a code owner June 8, 2023 16:17
clayjohn
clayjohn approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, luckily it looks like none of the internal uses of it rely on the default parameters or we would have had some really tough to debug bugs (as size and font_size have very different defaults)

@clayjohn clayjohn added this to the 4.1 milestone Jun 8, 2023
@akien-mga akien-mga merged commit e188d61 into godotengine:master Jun 8, 2023
@akien-mga
Copy link
Member

Thanks!

@Sauermann Sauermann deleted the fix-parameter-order branch June 8, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:core topic:2d
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Sauermann @akien-mga @clayjohn