Convert _scene_cull() to use parallel foreach()
#78016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 8, 2023
|
This PR passes the regression test in godotengine/godot-benchmarks#34 It has not tested with https://github.com/Calinou/godot-rendering-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #74118
Reduces the amount of code in the multithreaded culling path, which decreases lock contention and reduces the chances of any hidden race conditions lurking around (see #71705).
As a bonus, culling performance improves slightly for me (going from 1 -> 2 threads results in an average of 1.4x speedup rather than 1.3x), although obviously YMMV.
Depends on #74118 and #72784, marking as draft until those two are merged. Also has a soft dependency on #72716 (this PR works without it, but will likely result in performance regressions)