Fix parent inconsistency in Node::remove_child
#78019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NOTIFICATION_CHILD_ORDER_CHANGED` could be triggered, while there was an inconsistent state: - parent node no longer had child listed as child - child node still had parent node listed as parent Bring these two in sync, before emitting the notification.
RedworkDE
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
I have a branch with basically the exact same change: master...RedworkDE:inconsistent-child so I think the change is correct (and it solves the problem)
I left it at that over concerns about code that might depend on that weird state, given the age of this behavior, but such code is now broken anyways with the changed notification, so this change is safe now and it is better to keep nodes in a consistent state.
akien-mga
approved these changes
Jun 9, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTIFICATION_CHILD_ORDER_CHANGEDcould be triggered, while there was an inconsistent state:Bring these two in sync, before emitting the notification.
resolve #77870