Skeleton3D: Only reset rest_dirty after ALL bone transforms have finished update
#78025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
approved these changes
Jun 9, 2023
fire
added
cherrypick:4.0
cherrypick:4.1
TokageItLab
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Yes, I am pretty sure it is the global_rest calculation that is broken. This PR fix not only #77995 but also the issue of SkeletonGizmo not displaying correctly when there is more than one bone root.
force_update_bone_children_transforms() is only used one line of force_update_all_bone_transforms() and process for each parentless bones, so it would be correct to put dirty = false there.
akien-mga
removed
the
cherrypick:4.1
|
Thanks! |
akien-mga
changed the title
rest_dirty after ALL bone transforms have finished update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77995
Special thanks to @TokageItLab for identifying the line of code during a debug session. I wouldn't have found it without that.
cc @TokageItLab @fire