Move registration of fallbacks property in the base Font class

[Faolan-Rad]

No description provided.

[Faolan-Rad]

Put the property define where the get setter are defined

[akien-mga]

Thanks for your first contribution.

Could you clarify what motivates the change? It doesn't seem wrong per se but it's unclear what it's fixing, if anything.

You would also need to update the class reference to match the change of inheritance. See https://docs.godotengine.org/en/latest/contributing/documentation/updating_the_class_reference.html

[AThousandShips]

You're also making each case storage, I don't think FontVariation and SystemFont should store these, and that this setup is by design for that very reason

[bruvzg]

It was defined in the subclasses for the reason, fallback has, PROPERTY_USAGE_STORAGE flag for FontFile and default flags for the rest of fonts.

This change will hide fallback from the editor inspector UI for all types of fonts, which is wrong (it should be only hidden for FontFile since it's an imported resource and should not be modified manually).

[KoBeWi]

We usually handle such cases with _validate_property().
So fallbacks should be defined with the default usage and FontFile should have _validate_property() that unexposes it. (see box_container.cpp for example)

[Faolan-Rad]

The reason I noticed I am working on a code generator for a networking system that adds code into every set method and my code could not find the set method which seemed odd to me because this problem did show up else where in the code base and this is the only case I can find properties definitions exciting separate from where the methods are defined.

Also I added _validate_property to font file so it well tell it to be storage

I am doing this because it seems be a consistency issue

[AThousandShips]

The documentation needs to be updated for variation as well, it doesn't have that property any longer locally

[Faolan-Rad]

@AThousandShips I do not see what you are talking about or has this been already dealt with with my last force push

[AThousandShips]

The file FontVariation.xml still contains documentation for fallbacks, this wouldn't be generated so CI will fail, you'll need to remove this property from there, to verify please compile your code and run --doctool on the built editor

You also have to update your branch to the latest upstream version or CI will fail

[Faolan-Rad]

I just realized I forgot to save the file @AThousandShips that is why it was still there

[Faolan-Rad]

@AThousandShips so I should rebase it?

[AThousandShips]

My bad you were more out of date than I thought so it should be safe

[KoBeWi]

You should also squash the commits into 1 and remove me from co-authors.

[AThousandShips]

Still need to fix the documentation, methods for properties aren't exposed in the documentation

[YuriSizov]

By the way, this would technically be a breaking change for C#, at least.

[akien-mga]

Thanks!

[AThousandShips]

Broke API compat, was merged before the CI could report this, needs followup, let's make sure these specific CI pass before merging

[akien-mga]

My bad, CI was taking forever and I overlooked that it hadn't passed yet here.

Edit: Fixup: #80374.