Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clamp PathFollow3D progress when not looping #78280

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Clamp PathFollow3D progress when not looping #78280

merged 1 commit into from
Jun 16, 2023

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos added this to the 4.1 milestone Jun 15, 2023
@raulsntos raulsntos requested a review from a team as a code owner June 15, 2023 15:05
@raulsntos raulsntos mentioned this pull request Jun 15, 2023
Merged
@akien-mga
Copy link
Member

CC @xiongyaohua @TokageItLab

TokageItLab
TokageItLab approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have missed the review while that PR was in the process of being rebased many times. Yes, it should clamp if it is not looping.

@akien-mga akien-mga merged commit c6d9139 into godotengine:master Jun 16, 2023
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the path-follow-3d-clamp branch June 16, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TokageItLab TokageItLab TokageItLab approved these changes

Assignees
No one assigned
Labels
bug regression topic:core topic:3d
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@raulsntos @akien-mga @TokageItLab