Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the distance for grabbing a EditorSpinSlider #78318

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

Sauermann
Copy link
Contributor

Currently moving the mouse for a single pixel is enough to trigger grabbing, which happens often unintentionally.

resolve #78315
followup to #50671 which increased the change per pixel-move, but didn't adjust the minimal distance.

@akien-mga
Copy link
Member

Likely a regression from #50671, CC @winston-yallow.

It added a multiplication by grabbing_spinner_speed in grabbing_spinner_dist_cache, which explains why the same needs to be done on the right hand side now. Might be worth checking if there are more uses of grabbing_spinner_dist_cache that need the same treatment, and whether that speed should have been multiplied there in the first place.

@Sauermann
Copy link
Contributor Author

Might be worth checking if there are more uses of grabbing_spinner_dist_cache that need the same treatment

I did investigate this question, but didn't find any obvious place, where the same treatment was required.

@akien-mga
Copy link
Member

Ah yes I just see in your OP that you actually linked to that PR already, my bad :)

@Sauermann Sauermann force-pushed the fix-spinslider-grabbing branch from 2bd8d2b to a7ebbd9 Compare June 16, 2023 07:38
Currently moving the mouse for a single pixel is enough to trigger
grabbing, which happens often unintentionally.
@Sauermann Sauermann force-pushed the fix-spinslider-grabbing branch from a7ebbd9 to 42402aa Compare June 16, 2023 07:40
@akien-mga akien-mga merged commit ada10b5 into godotengine:master Jun 16, 2023
@Sauermann Sauermann deleted the fix-spinslider-grabbing branch June 16, 2023 08:48
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwarranted value incremented in text boxes on focus
2 participants