Make GraphEdit's cpp virtuals equal to gdscript. #78426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
approved these changes
Jun 19, 2023
|
Needs rebase after #79308. CC @Geometror |
Daylily-Zeleen
force-pushed
the
daylily-zeleen/graph_edit_virtual
branch
from
7987b15
to
8275806
Compare
Done. |
akien-mga
approved these changes
Aug 8, 2023
YuriSizov
suggested changes
Aug 8, 2023
Daylily-Zeleen
force-pushed
the
daylily-zeleen/graph_edit_virtual
branch
from
8275806
to
2f0639e
Compare
YuriSizov
approved these changes
Aug 8, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some GraphEdit's methods can be overrided in GDScript but can't be overrided in C++, I don't know it is Intentional or not, but it blocking the development of godot module.