Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Check if JetBrains Rider editor path is empty #78516

Merged

Conversation

raulsntos
Copy link
Member

  • Add check to see if the path to Rider is empty before attempting to start a process. If so, show a better error to the user.
  • Enable nullability in RiderPathManager and remove unnecessary null checks when we know the string can't be null.
  • Make EditorPathSettingName a private constant, it doesn't seem like it was being used anywhere outside of this class.

I don't have Rider so I couldn't test but the changes seem safe.

@raulsntos raulsntos added this to the 4.x milestone Jun 21, 2023
@raulsntos raulsntos requested a review from a team as a code owner June 21, 2023 11:11
@YuriSizov YuriSizov modified the milestones: 4.x, 4.2 Jun 21, 2023
@raulsntos raulsntos force-pushed the dotnet/check-rider-path-is-empty branch from bed789b to f11e600 Compare July 8, 2023 17:17
@raulsntos raulsntos force-pushed the dotnet/check-rider-path-is-empty branch from f11e600 to 5f6524a Compare September 13, 2023 23:56
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good code improvement.

@akien-mga akien-mga merged commit 26493ca into godotengine:master Sep 14, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/check-rider-path-is-empty branch September 14, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants