Unify debug/non-debug behavior of ClassDB::get_method_info()
#78537
+4
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvilfolk
force-pushed
the
unify-classDB-method-info
branch
from
de83993 to
f14987d
Compare
anvilfolk
commented
Jun 21, 2023
| @@ -116,12 +116,12 @@ class ClassDB { | |||
| HashMap<StringName, MethodInfo> signal_map; | |||
| List<PropertyInfo> property_list; | |||
| HashMap<StringName, PropertyInfo> property_map; | |||
| List<MethodInfo> virtual_methods; | |||
There was a problem hiding this comment.
I'm not 100% certain that moving virtual_methods out of DEBUG_METHODS_ENABLED is absolutely needed to fix the linked issue, but this makes the handling of virtual methods consistent, e.g. you can find the same things through get_method_info(), and get_method_list().
Currently only debug builds allow `ClassDB::get_method_info()` to check for virtual methods. As a result, debug builds will not generate errors when e.g. calling virtual methods (meant to act as a no-op). Non-debug builds, however, will complain that those methods do not exist, when they should also behave as a no-op. Fixes godotengine#76938 (again).
anvilfolk
force-pushed
the
unify-classDB-method-info
branch
from
f14987d to
ccb6c85
Compare
|
This might fix #65534 as well? Although reduz commented there saying this is done by design. |
|
The linked issue seems to be fixed by your other PR now, #81808. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only debug builds allow
ClassDB::get_method_info()to check for virtual methods. As a result, debug builds will not generate errors when e.g. calling virtual methods (meant to act as a no-op). Non-debug builds, however, will complain that those methods do not exist, when they should also behave as a no-op.Fixes #76938 (again).
This is failing release builds because the information about virtual methods currently does not get stored in release builds. For this to work, we'd need to store that information, which doesn't feel great - but there might not be a way around that.
Thoughts?