Add the ability to get per-platform information for joypads #78539
Conversation
|
Updated with changes suggested by @RandomShaper on the original PR |
EIREXE
force-pushed
the
input-info
branch
2 times, most recently
from
a43c172
to
35da933
Compare
There was a problem hiding this comment.
Looks good!
NOTE: This will have to wait until #76045 is merged as it may need a new rebase.
|
Sure, i'll wait |
|
@RandomShaper I rebased it, not sure why the test with ASAN fails, is it an issue with CI or is there something I did wrong? |
|
It's a ci/buildsystem bug, it's being tracked :) |
|
Good to go then! |
|
Should be good now. |
|
@EIREXE I know this seems minor, but could you please be more careful with formatting? Platform names must be correctly capitalized in your newly added documentation. You also missed one instance of that in my suggestion for "Steam Input", which is a proper name. It's best to make sure these don't slip into your PRs to begin with, as we will point them out and it will add to your work fixing and rebasing those, and will make the PR process longer for every side. Thanks 🙏 |
Yeah sorry, I'm very forgetful and easily distracted, i'll take a look. |
This adds the ability for games to obtain platform-specific information about joypads such as their vendor/product ID, their XInput gamepad index or the real name of the device before it gets swapped out by the gamecontrollerdb's name. This PR also includes a rebased version of godotengine#76045, this is because this PR is intended to be mainly to help people implementing Steam Input, as having the gamepad index is essential.
|
Thanks! |
This adds the ability for games to obtain platform-specific information about joypads such as their vendor/product ID, their XInput gamepad index or the real name of the device before it gets swapped out by the gamecontrollerdb's name.
The rationale behind this being returned as a
Dictionaryis that there's a big disparity between input and OS APIs, so it makes more sense to have a single "extra info" function.This PR also includes a rebased version of #76045, this is because this PR is intended to be mainly to help implementing Steam Input glyphs, as some information needed for that is not accessible in the engine normally.