Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to center image when loading particle emission mask #78583

Closed
wants to merge 0 commits into from

Conversation

bgie
Copy link
Contributor

@bgie bgie commented Jun 22, 2023

When loading an image to use as a particle emission mask, the option to center the image is now available. The centering is applied when generating the mask, so no extra runtime cost is involved.

Fixes #16411

@bgie bgie requested a review from a team as a code owner June 22, 2023 20:26
@bgie
Copy link
Contributor Author

bgie commented Jun 22, 2023

First contribution to the project, so do let me know if I missed some guideline, would be happy to fix it.

@KoBeWi
Copy link
Member

KoBeWi commented Jun 27, 2023

Having a separate section for each checkbox is a bit awkward.
image
I think Centered and Capture from Pixel should be under one section, although the latter might need to be renamed. Something like

Options

  • Centered
  • Capture Colors from Pixel

@Calinou
Copy link
Member

Calinou commented Jul 2, 2023

@bgie It looks like you force-pushed your branch in a way that makes it have no commits, which means GitHub automatically closed the pull request.

You need to open a new pull request with a different branch name – do not use your fork's master branch as your branch for pull requests.

@bgie
Copy link
Contributor Author

bgie commented Jul 2, 2023

@Calinou Thanks for the clarification and clear instructions.
I had noticed I was working on master and tried to correct that, not considering that the pull request is apparently (obviously) linked to a branch name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2D Particle Emission Mask is offset
4 participants