GLTF: Internal renames in material parsing code #78622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RevoluPowered
approved these changes
Jun 23, 2023
fire
approved these changes
Jun 23, 2023
aaronfranke
force-pushed
the
gltf-mat-int-rename
branch
from
8ca3b98
to
865d7e3
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dtomaterial_dict. This is a Dictionary representing a glTF material.pbr_spec_gloss_extensionstomaterial_extensions. This is a Dictionary of the extensions in the glTF material, including unlit and spec gloss, not just spec gloss.This will conflict with #78621 (we can merge that first and I will rebase this PR).