Tweak documentation to use bold font when a class is referencing itself #78649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
approved these changes
Jun 24, 2023
There was a problem hiding this comment.
Tested locally, it works:
I'm not sure why the underline is missing on OP's screenshot; it's present just fine here. Maybe your custom editor font is causing it to disappear due to the underline width not being read correctly (or not being clamped to be at least 1 pixel)?
For reference, MediaWiki also highlights self-page references in bold with no URL. Therefore, the overall idea looks good to me.
Regarding the implementation, I can't think of a better way to do it.
The first image is how it's after the PR, the second image is a comparison with the website, sorry for not being clear. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how the website does it.
Please take a look at the implementation as there might be a better way.