Set language encoding flag when using ZIPPacker

[timothyqiu]

• Fixes Naming files in Chinese, ZIPPacker and ZIPReader will generate Garbled code #78726
• Fixes It is not possible to add/read files named by non-ASCII characters using ZIPPackage and ZIPReader #85676

This PR sets the "Language Encoding Flag" when opening a new file in zip. This flag indicates that the filename and comment fields are encoded using UTF-8¹, so zip readers like ZIPReader can then parse the filename correctly.

Extra parameters passed to zipOpenNewFileInZip4 in this PR are the same as ones zipOpenNewFileInZip will pass to it.

Footnotes

1. https://pkware.cachefly.net/webdocs/APPNOTE/APPNOTE-6.3.9.TXT ↩

[zedrun00]

Yes, the display is normal now, but ZIPReader cannot then parse the filename correctly.

E 0:00:00:0405   test.gd:76 @ read_zip_file(): File does not exist in zip archive: 中���.tscn
  <C++ 错误>       Method/function failed. Returning: PackedByteArray()
  <C++ 源文件>      modules\zip\zip_reader.cpp:92 @ read_file()
  <栈追踪>          test.gd:76 @ read_zip_file()
                 test.gd:8 @ _ready()

The problem originates from ZIPReader.get_files()

[timothyqiu]

@zedrun00 Please make sure you are reading the zip file created by ZIPPacker. Your reproduction project attached in the original issue is always reading 7z.zip instead of godot.zip.

[zedrun00]

@zedrun00 Please make sure you are reading the zip file created by ZIPPacker. Your reproduction project attached in the original issue is always reading 7z.zip instead of godot.zip.

Yes ,this is local code:

func _ready():
	#write_zip_dir("res://zh_CN/", "res://godot.zip")
	read_zip_file("res://godot.zip", "res://test")
	#read_zip_file("res://p.zip", "res://test")

[zedrun00]

Forgive me for coming late. The bug in v4.1.dev4.official [5c2295ff5] repaired. be related to #69677

[akien-mga]

So you mean that the bug is already fixed in the current 4.1 version (so also 4.1.rc1)?

But in #78732 (comment) you tested this PR and still had problems, were you testing the patch on top of the 4.0 or 4.1 branch?

[zedrun00]

So you mean that the bug is already fixed in the current 4.1 version (so also 4.1.rc1)?

But in #78732 (comment) you tested this PR and still had problems, were you testing the patch on top of the 4.0 or 4.1 branch?

#78732 will solve file name garbled. but garbled does not affect ZIPReader::read_file()

ZIPReader::read_file() doesn't work because of "ZIPReader::get_files()" err

#69677 Fixed a memory leak when using long filepaths (>256 characters) inZIPReader::get_files()

[zedrun00]

Forgive me for my foolish English
The pr fixesed #78726
The pr should be merged.

[bruvzg]

It's working with all archivers I have tested (seems like setting the "version made by" is enough for most software).

There are two places in the editor/export/editor_export_platform.cpp that are using zipOpenNewFileInZip4, these probably should be changed to set bit 11 as well.

[akien-mga]

Thanks!

[YuriSizov]

Cherry-picked for 4.2.1.

[Kesha2447]

Will this be fixed in the upcoming releases? It still gets in the way a lot.

[AThousandShips]

This is in 4.2.1 (it was even mentioned in the release post 🙂) it will also likely be in a future 4.1.x release

[YuriSizov]

Cherry-picked for 4.1.4.